Use filepath relative to repo root #22
Conversation
|
|
|
Check release failure is caused by pypa/hatch#1793 |
This has now been fixed |
|
Whoops |
|
Thanks @juntyr for opening this. The error in check-release does not seem to be related to pypa/hatch#1793 any more. I can reproduce it locally by running @jtpio do you have a clue on this error ? |
|
Strange. We've seen that error before on another repo ( But if it keeps happening we should investigate more, as it may be an issue with the releaser. |
|
Right, it was jupyterlab/jupyter-collaboration#378 Opening a new PR fixed the error |
|
Should I close this PR and open a fresh one? |
yes, we can try that. |
The extension template has a |
Maybe we can open an issue on the releaser repo to have a look at some point? |
3 participants
The docs mention that the
urlpathparameter is relative to the repository root (see https://litegitpuller.readthedocs.io/en/latest/index.html#parameters), which is currently not the case.This PR fixes the code to interpret the
urlpathparameter relative to the repository root, which is a breaking change. This behaviour is useful when the repo is not uploaded to a statically known path, e.g. by (in the future) uploading it to the currently opened working directory.While we theoretically could detect paths starting with
tree/to get back the original behaviour, this would clash with folders namedtreeinside the repository. Opening a path outside the repo is still possible by giving an absolute path, e.g./README.md(since absolute paths come out of a join unchanged and JupyterLab strips the leading slash).